-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set explicit rules about naming convention #165
Labels
Comments
mayurkale22
added
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Aug 6, 2019
@OlivierAlbertini - SGTM. Would you be open to take this one and provide a PR? |
Sure |
danielkhan
removed
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Aug 7, 2019
OlivierAlbertini
added a commit
to OlivierAlbertini/opentelemetry-js
that referenced
this issue
Sep 14, 2019
closes open-telemetry#165 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
added a commit
to OlivierAlbertini/opentelemetry-js
that referenced
this issue
Sep 14, 2019
closes open-telemetry#165 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
added a commit
to OlivierAlbertini/opentelemetry-js
that referenced
this issue
Sep 14, 2019
closes open-telemetry#165 Signed-off-by: Olivier Albertini <[email protected]>
mayurkale22
pushed a commit
that referenced
this issue
Sep 17, 2019
closes #165 Signed-off-by: Olivier Albertini <[email protected]>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this issue
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
PR review should not need to check naming convention as it should be caught by CI.
Here an existing package: https://www.npmjs.com/package/tslint-consistent-codestyle#naming-convention
I will check if newer tslint version does already this...
This is an example. Don't hesitate to add your requirements by adding a comment
Describe the solution you'd like
We should explicitly add rules for naming convention
We should start after #106 (review) is merged
The text was updated successfully, but these errors were encountered: