Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit rules about naming convention #165

Closed
OlivierAlbertini opened this issue Aug 6, 2019 · 2 comments · Fixed by #262
Closed

Set explicit rules about naming convention #165

OlivierAlbertini opened this issue Aug 6, 2019 · 2 comments · Fixed by #262
Assignees

Comments

@OlivierAlbertini
Copy link
Member

OlivierAlbertini commented Aug 6, 2019

Is your feature request related to a problem? Please describe.
PR review should not need to check naming convention as it should be caught by CI.

Here an existing package: https://www.npmjs.com/package/tslint-consistent-codestyle#naming-convention

I will check if newer tslint version does already this...

"naming-convention": [true,
{"type": "method", "modifiers": "protected", "leadingUnderscore": "require"},
{"type": "member", "modifiers": "protected", "leadingUnderscore": "require"},
{"type": "member", "modifiers": "private", "leadingUnderscore": "require"},
{"type": "enumMember", "format": "PascalCase"},
{"type": "property", "modifiers": ["static"], "format": "UPPER_CASE"}
]

This is an example. Don't hesitate to add your requirements by adding a comment

Describe the solution you'd like
We should explicitly add rules for naming convention

We should start after #106 (review) is merged

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 6, 2019
@danielkhan
Copy link
Contributor

@OlivierAlbertini - SGTM. Would you be open to take this one and provide a PR?

@OlivierAlbertini
Copy link
Member Author

@OlivierAlbertini - SGTM. Would you be open to take this one and provide a PR?

Sure

@danielkhan danielkhan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 7, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Sep 14, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Sep 14, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Sep 14, 2019
mayurkale22 pushed a commit that referenced this issue Sep 17, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants