Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - allow long lines for tables and code blocks #3049

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 15, 2022

Fixes #2917.

Changes

Introduce md lint config file.
Allow long lines for code-block and tables.
Remove obsolete markups.

@Kielek Kielek requested a review from a team March 15, 2022 11:34
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #3049 (d3fd053) into main (a709cfd) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3049      +/-   ##
==========================================
- Coverage   84.84%   84.75%   -0.09%     
==========================================
  Files         259      259              
  Lines        9112     9112              
==========================================
- Hits         7731     7723       -8     
- Misses       1381     1389       +8     
Impacted Files Coverage Δ
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 86.53% <0.00%> (-5.77%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 73.68% <0.00%> (-1.76%) ⬇️

@@ -2,7 +2,7 @@ name: markdownlint

on:
push:
branches: [ main, metrics ]
branches: [ long-lines-linting ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional? I guess not..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no... I have attached wrong file to the first commit.
It should be in another one, used to execute pipeline on fork.

Fixed afc2d71

@Kielek Kielek requested a review from cijothomas March 15, 2022 17:27
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! 👍 LGTM.

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globally allow long lines for code_blocks and tables
4 participants