Fix conditional compilation in aspnetcore instrumentation #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main open-telemetry/opentelemetry-dotnet#3025 +/- ##
==========================================
+ Coverage 84.69% 84.74% +0.04%
==========================================
Files 258 258
Lines 9095 9105 +10
==========================================
+ Hits 7703 7716 +13
+ Misses 1392 1389 -3
|
reyang
reviewed
Mar 11, 2022
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
pellared
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards open-telemetry/opentelemetry-dotnet-contrib#1777
I think this will truly make the benefits from https://github.com/open-telemetry/opentelemetry-dotnet/pull/2947/files available to newer frameworks like NET5.0, NET6.0, which was the intent as well.