Review the conditional compilations in ASPNET Core and other instrumentations. #1777
Labels
bug
Something isn't working
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
help wanted
Extra attention is needed
infra
Infra work - CI/CD, code coverage, linters
Due to the addition of more targets like net5.0 and net6.0 to the instrumention projects, the conditional checks inside the code seems broken now.
example:
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L313 check for
#if NETSTANDARD2_1
, means that code path is not triggered for net5.0 or net6.0Opening an issue to do a round of reviews to make sure the conditional compilation flags are still correct, after the addition of new project targets.
The text was updated successfully, but these errors were encountered: