Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update check-changes to match the release docs #7817

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

codeboten
Copy link
Contributor

Don't prefix the version number w/ a v as the docs already tell the release manager to do so, plus this way it's easier to copy/paste the version from the module set.

@codeboten codeboten requested review from a team and dmitryax June 5, 2023 15:33
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (897a316) 90.82% compared to head (4be3d6e) 91.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7817      +/-   ##
==========================================
+ Coverage   90.82%   91.05%   +0.23%     
==========================================
  Files         296      296              
  Lines       14840    14800      -40     
==========================================
- Hits        13478    13476       -2     
+ Misses       1087     1046      -41     
- Partials      275      278       +3     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten marked this pull request as draft June 5, 2023 15:53
Alex Boten added 2 commits June 7, 2023 11:48
Don't prefix the version number w/ a `v` as the docs already tell the release manager to do so, plus this way it's easier to copy/paste the version from the module set.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/update-makefile branch from 46c869a to 4be3d6e Compare June 7, 2023 19:10
@codeboten codeboten marked this pull request as ready for review June 7, 2023 19:10
@codeboten codeboten merged commit 5d032e9 into open-telemetry:main Jun 7, 2023
@codeboten codeboten deleted the codeboten/update-makefile branch June 7, 2023 19:27
@github-actions github-actions bot added this to the next release milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants