Skip to content

Commit

Permalink
[chore] update check-changes to match the release docs
Browse files Browse the repository at this point in the history
Don't prefix the version number w/ a `v` as the docs already tell the release manager to do so, plus this way it's easier to copy/paste the version from the module set.

Signed-off-by: Alex Boten <[email protected]>
  • Loading branch information
Alex Boten committed Jun 5, 2023
1 parent 371fc45 commit 46c869a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -397,19 +397,19 @@ endif
changed_files=""; \
for mod in $${mods}; do \
if [ "$${mod}" == "go.opentelemetry.io/collector" ]; then \
changed_files+=$$(git diff --name-only v$(PREVIOUS_VERSION) -- $$(printf '%s\n' $${all_submods[@]} | sed 's/^/:!/' | paste -sd' ' -) | grep -E '.+\.go$$'); \
elif ! git rev-parse --quiet --verify $${mod}/v$(PREVIOUS_VERSION) >/dev/null; then \
echo "Module $${mod} does not have a v$(PREVIOUS_VERSION) tag"; \
changed_files+=$$(git diff --name-only $(PREVIOUS_VERSION) -- $$(printf '%s\n' $${all_submods[@]} | sed 's/^/:!/' | paste -sd' ' -) | grep -E '.+\.go$$'); \
elif ! git rev-parse --quiet --verify $${mod}/$(PREVIOUS_VERSION) >/dev/null; then \
echo "Module $${mod} does not have a $(PREVIOUS_VERSION) tag"; \
echo "$(MODSET) release is required."; \
exit 0; \
else \
changed_files+=$$(git diff --name-only $${mod}/v$(PREVIOUS_VERSION) -- $${mod} | grep -E '.+\.go$$'); \
changed_files+=$$(git diff --name-only $${mod}/$(PREVIOUS_VERSION) -- $${mod} | grep -E '.+\.go$$'); \
fi; \
done; \
if [ -n "$${changed_files}" ]; then \
echo "The following files changed in $(MODSET) modules since v$(PREVIOUS_VERSION): $${changed_files}"; \
echo "The following files changed in $(MODSET) modules since $(PREVIOUS_VERSION): $${changed_files}"; \
else \
echo "No $(MODSET) modules have changed since v$(PREVIOUS_VERSION)"; \
echo "No $(MODSET) modules have changed since $(PREVIOUS_VERSION)"; \
echo "No need to release $(MODSET)."; \
exit 1; \
fi
Expand Down

0 comments on commit 46c869a

Please sign in to comment.