Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][update-otel] Tidy after generating the code #37440

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[chore][update-otel] Tidy after generating the code #37440

merged 1 commit into from
Jan 23, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 23, 2025

Description

Adds an extra make gotidy after make generate and make crosslink

See #37437 for example where it failed because of this.

@mx-psi mx-psi requested a review from a team as a code owner January 23, 2025 12:49
This was referenced Jan 23, 2025
Closed
Closed
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jan 23, 2025
@mx-psi mx-psi merged commit 68fa024 into open-telemetry:main Jan 23, 2025
176 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 23, 2025
codeboten pushed a commit that referenced this pull request Jan 24, 2025
@evan-bradley
[chore][update-otel] Tidy after generating the code (#37440) (#37476)
c37b272 
Fixes issues that arise from the recent promotion of
`exporter.UsePullingBasedExporterQueueBatcher` from alpha to beta.

Needed for
#37447.
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@mx-psi @chengchuanpeng
[chore][update-otel] Tidy after generating the code (open-telemetry#3…
4e772d1 
…7440)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds an extra `make gotidy` after `make generate` and `make crosslink`

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->

See open-telemetry#37437 for example where it failed because of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@bogdandrutu bogdandrutu

Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
3 participants
@mx-psi @songy23 @bogdandrutu