[chore] Fix OTel Arrow Exporter test with new queue batcher enabled #37476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
MovieStoreGuy
and removed request for
a team
evan-bradley
commented
Jan 24, 2025
Comment on lines
+935
to
+936
| cfg.Arrow.NumStreams = 1 | ||
| cfg.Arrow.MaxStreamLifetime = 100 * time.Second |
There was a problem hiding this comment.
Setting these directly rather than through a new struct keeps the default values for other fields.
codeboten
approved these changes
Jan 24, 2025
codeboten
merged commit c37b272
into
open-telemetry:opentelemetrybot/update-otel-1737650898
148 of 157 checks passed
evan-bradley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues that arise from the recent promotion of
exporter.UsePullingBasedExporterQueueBatcherfrom alpha to beta.Needed for #37447.