Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalFx exporter changes to match code review associated with Splunk HEC exporter #255

Merged
merged 2 commits into from
Jun 6, 2020
Merged

SignalFx exporter changes to match code review associated with Splunk HEC exporter #255

merged 2 commits into from
Jun 6, 2020

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 22, 2020

Description:
Some changes trickling down from review of #246 - following the same change recommendations for SignalFx.

@atoulme atoulme requested a review from a team May 22, 2020 00:05
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #255 into master will increase coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   79.33%   79.44%   +0.11%     
==========================================
  Files         163      163              
  Lines        8347     8344       -3     
==========================================
+ Hits         6622     6629       +7     
+ Misses       1363     1355       -8     
+ Partials      362      360       -2
Impacted Files Coverage Δ
exporter/signalfxexporter/exporter.go 85.41% <ø> (-0.86%) ⬇️
...orter/signalfxexporter/metricdata_to_signalfxv2.go 88.57% <33.33%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f640b71...e6fa712. Read the comment docs.

@tigrannajaryan
Copy link
Member

tigrannajaryan commented May 22, 2020 •
edited
Loading

@atoulme please use more specific PR titles and commit messages. The current title is very generic and does not help the reviewers or future readers of commit history.

@atoulme atoulme changed the title code review changes changes to signalfx exporter, based on code review comments on the splunk hec exporter May 22, 2020
@atoulme
Copy link
Contributor Author

atoulme commented May 22, 2020

Sure thing, done.

@atoulme atoulme changed the title changes to signalfx exporter, based on code review comments on the splunk hec exporter SignalFx exporter changes to match code review associated with Splunk HEC exporter May 22, 2020
@jrcamp jrcamp removed their assignment May 27, 2020
@tigrannajaryan
Copy link
Member

@atoulme you probably need to add some tests to please codecov, I am unable to merge without it stamping the PR.

@tigrannajaryan tigrannajaryan self-assigned this Jun 4, 2020
@bogdandrutu
Copy link
Member

@atoulme please rebase and add some tests to make codecov happy :)

@atoulme atoulme requested a review from a team June 5, 2020 23:50
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2020 •
edited
Loading

CLA Check

@atoulme
Copy link
Contributor Author

atoulme commented Jun 6, 2020

I rebased and added a test.

@bogdandrutu bogdandrutu merged commit ab093e2 into open-telemetry:master Jun 6, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@atoulme @wyTrivail
SignalFx exporter changes to match code review associated with Splunk…
f8c0e6e 
… HEC exporter (#255)

* Bring changes to signalfx exporter matching code review comments of #246

* Add test checking for invalid distribution without buckets
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
@tigrannajaryan
Fix typo in error message (#255)
22a9985 
Signed-off-by: Guangming Wang <[email protected]>
@atoulme atoulme mentioned this pull request Sep 18, 2020
Closed
6 tasks
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@jmacd
Remove NewZeroNumber in favor of Number(0) (#255)
88dafbb
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
@dependabot
Bump github.com/securego/gosec/v2 from 2.8.0 to 2.8.1 in /internal/to…
a7e46cc 
…ols (#255)

Bumps [github.com/securego/gosec/v2](https://github.com/securego/gosec) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/securego/gosec/releases)
- [Changelog](https://github.com/securego/gosec/blob/master/.goreleaser.yml)
- [Commits](securego/gosec@v2.8.0...v2.8.1)

---
updated-dependencies:
- dependency-name: github.com/securego/gosec/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jj22ee added a commit to jj22ee/opentelemetry-collector-contrib that referenced this pull request Nov 15, 2024
@jj22ee
upgrade OCB components to v0.111.0 (open-telemetry#255)
1bf0ac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcamp jrcamp jrcamp approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @tigrannajaryan @bogdandrutu @jrcamp