SignalFx exporter changes to match code review associated with Splunk…

… HEC exporter (#255) * Bring changes to signalfx exporter matching code review comments of #246 * Add test checking for invalid distribution without buckets
open-telemetry · Jun 6, 2020 · ab093e2 · ab093e2
1 parent be43dbc
commit ab093e2
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 8 deletions.
diff --git a/exporter/signalfxexporter/exporter.go b/exporter/signalfxexporter/exporter.go
@@ -64,11 +64,6 @@ func New(
 			fmt.Errorf("failed to process %q config: %v", config.Name(), err)
 	}
 
-	if config.Name() == "" {
-		config.SetType(typeStr)
-		config.SetName(typeStr)
-	}
-
 	headers, err := buildHeaders(config)
 	if err != nil {
 		return nil, err

diff --git a/exporter/signalfxexporter/metricdata_to_signalfxv2.go b/exporter/signalfxexporter/metricdata_to_signalfxv2.go
@@ -163,7 +163,7 @@ func metricDataToSignalFxV2(
 						logger.Warn(
 							"Timeseries for distribution metric dropped",
 							zap.Error(err),
-							zap.String("Metric", *sfxDataPoint.Metric))
+							zap.String("metric", *sfxDataPoint.Metric))
 					}
 				case *metricspb.Point_SummaryValue:
 					sfxDataPoints, err = appendSummaryValues(
@@ -175,13 +175,13 @@ func metricDataToSignalFxV2(
 						logger.Warn(
 							"Timeseries for summary metric dropped",
 							zap.Error(err),
-							zap.String("Metric", *sfxDataPoint.Metric))
+							zap.String("metric", *sfxDataPoint.Metric))
 					}
 				default:
 					numDroppedTimeSeries++
 					logger.Warn(
 						"Timeseries dropped to unexpected metric type",
-						zap.String("Metric", *sfxDataPoint.Metric))
+						zap.String("metric", *sfxDataPoint.Metric))
 				}
 
 			}

diff --git a/exporter/signalfxexporter/metricdata_to_signalfxv2_test.go b/exporter/signalfxexporter/metricdata_to_signalfxv2_test.go
@@ -336,3 +336,37 @@ func expectedFromSummary(
 
 	return dps
 }
+
+func Test_InvalidDistribution_NoExplicitBuckets(t *testing.T) {
+	logger := zap.NewNop()
+	unixSecs := int64(1574092046)
+	unixNSecs := int64(11 * time.Millisecond)
+	tsUnix := time.Unix(unixSecs, unixNSecs)
+	keys := []string{"k0", "k1"}
+	values := []string{"v0", "v1"}
+	buckets := make([]*metricspb.DistributionValue_Bucket, 2)
+
+	distrValue := &metricspb.DistributionValue{
+		BucketOptions: &metricspb.DistributionValue_BucketOptions{
+			Type: &metricspb.DistributionValue_BucketOptions_Explicit_{
+				Explicit: nil,
+			},
+		},
+		Count:   42,
+		Sum:     42,
+		Buckets: buckets,
+	}
+	point := &metricspb.Point{Timestamp: metricstestutils.Timestamp(tsUnix), Value: &metricspb.Point_DistributionValue{DistributionValue: distrValue}}
+	point.GetDistributionValue().BucketOptions.GetExplicit()
+	metricData := consumerdata.MetricsData{
+		Metrics: []*metricspb.Metric{
+			metricstestutils.GaugeDist("gauge_distrib", keys, metricstestutils.Timeseries(
+				tsUnix,
+				values,
+				point)),
+		},
+	}
+	_, gotNumDroppedTimeSeries, err := metricDataToSignalFxV2(logger, metricData)
+	assert.Equal(t, 1, gotNumDroppedTimeSeries)
+	assert.NoError(t, err)
+}