Revert "[exporter/datadog] Set Capabilities on metrics exporter" #25098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 4f2f416.
github-actions
bot
requested review from
dineshg13,
gbbr,
liustanley and
mackjmr
|
Thinking more over this - we may still modify the metric names in the input If so, feel free to close this PR. |
mx-psi
requested changes
Aug 9, 2023
There was a problem hiding this comment.
Indeed, I think we would need to refactor https://github.com/DataDog/opentelemetry-mapping-go/blob/0a32610fd1a87d46b4b499bc3e70ef1f23b169e4/pkg/otlp/metrics/metrics_remapping.go#L73 if we want to revert this PR
|
Yep that sounds correct to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24979
With DataDog/opentelemetry-mapping-go#148 and #25071 we are no longer mutating the input metrics, thus #24979 is not needed.