Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[pkg/otlp] Correctly set serializer exporter capabilities" #18697

Closed
wants to merge 1 commit into from

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Aug 8, 2023

Reverts #18626

With DataDog/opentelemetry-mapping-go#148 and #18606 we are no longer mutating the input metrics, thus #18626 is not needed.

@songy23 songy23 added this to the 7.48.0 milestone Aug 8, 2023
@songy23 songy23 requested a review from mx-psi August 8, 2023 20:27
@songy23 songy23 requested review from a team as code owners August 8, 2023 20:27
@songy23
Copy link
Member Author

songy23 commented Aug 8, 2023

Same comment as open-telemetry/opentelemetry-collector-contrib#25098 (comment), not sure if we need this revert PR.

@pr-commenter
Copy link

pr-commenter bot commented Aug 8, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8aca8d4e-1fc4-48cf-94e5-e78ea34e3dd2
Baseline: 59ff4f6
Comparison: 95218f2
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput +0.35 [-0.23, +0.94] 55.81%
uds_dogstatsd_to_api ingress throughput +0.13 [-0.67, +0.93] 16.61%
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 33.07%
trace_agent_json ingress throughput -0.02 [-0.06, +0.02] 45.72%
trace_agent_msgpack ingress throughput -0.06 [-0.11, -0.02] 91.00%
tcp_syslog_to_blackhole ingress throughput -0.12 [-0.21, -0.03] 92.27%
file_to_blackhole egress throughput -0.25 [-1.18, +0.69] 26.34%

mx-psi
mx-psi previously approved these changes Aug 9, 2023
@mx-psi mx-psi added component/otlp PRs and issues related to OTLP ingest team/opentelemetry OpenTelemetry team labels Aug 9, 2023
@mx-psi mx-psi dismissed their stale review August 9, 2023 08:23

We can't actually do this yet

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songy23 songy23 closed this Aug 9, 2023
@songy23 songy23 deleted the revert-18626-mx-psi/fix-panic branch August 9, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/otlp PRs and issues related to OTLP ingest team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants