[exporter/awsemf] Add feature gate for default dimension rollup #24274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Jul 16, 2023
atoulme
reviewed
Jul 16, 2023
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Aneurysm9
approved these changes
Jul 19, 2023
Co-authored-by: Anthony Mirabella <[email protected]>
songy23
added
the
ready to merge
atoulme
removed
the
ready to merge
|
Please attend to the failing build. |
|
@atoulme updating main resolved failures. |
|
@open-telemetry/collector-contrib-maintainer this has been ready for merge for 3 weeks now. The only failing tests that occur are flakes after continually having to update with main branch. |
TylerHelmuth
approved these changes
Aug 4, 2023
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add feature gate to change default DimensionRollupOption. This was introduced as a feature gate since it will be a breaking change when switching to Beta.
Link to tracking Issue: #23997
Testing: Added unit tests
Documentation: Updated readme.