-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awsemf] set default dimension_rollup_option
to NoDimensionRollup
#23997
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
dimension_rollup_option
to NoDimensionRollup
dimension_rollup_option
to NoDimensionRollup
Hi @abarganier, thanks for bringing up this issue. I think the cost of the |
@bryan-aguilar thank you for the response. Would love to see this merged & eventually become the default. |
**Description:** Add feature gate to change default DimensionRollupOption. This was introduced as a feature gate since it will be a breaking change when switching to Beta. **Link to tracking Issue:** #23997 **Testing:** Added unit tests **Documentation:** Updated readme. --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/awsemf
Is your feature request related to a problem? Please describe.
Currently, the
dimension_rollup_option
defaults toZeroAndSingleDimensionRollup
. This leads to an expensive explosion of metric counts in CloudWatch once ingested.For example, if you have a metric:
my_metric{label1="a", label2="b"}
The CloudWatch exporter was exporting this as three unique metrics (potentially more?):
As with most standard timeseries databases/monitoring systems, the default behavior here should be to just treat this is a single metric,
my_metric{label1="a", label2="b"}
.To have the default behavior be anything different leads to large CloudWatch bills, where billing is done per-metric. This means that exploding a single metric into multiple drives the bill up considerably, and quite frankly, since I don't see any utility in decomposing a label set into multiple metrics per-label, it seems like the bill is high for no good reason.
Describe the solution you'd like
The default value of
dimension_rollup_option
should beNoDimensionRollup
to avoid unexpected huge CloudWatch bills, where users can "opt-in" to the more expensive options if they choose to.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: