Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] use type in apache receiver #21272

Merged
merged 2 commits into from
May 11, 2023
Merged

[chore] use type in apache receiver #21272

merged 2 commits into from
May 11, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 1, 2023

This has the effect of changing the scope instrumentation library name.

@atoulme atoulme requested a review from a team May 1, 2023 05:59
@atoulme atoulme requested a review from djaglowski as a code owner May 1, 2023 05:59
@atoulme atoulme force-pushed the use_type_in_apache_receiver branch from f26e341 to 0465fdd Compare May 1, 2023 08:09
@dmitryax dmitryax mentioned this pull request May 1, 2023
Merged
@atoulme atoulme added discussion needed Community discussion needed needs triage New item requiring triage and removed needs triage New item requiring triage labels May 1, 2023
codeboten
codeboten previously requested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking request for change to ensure an agreement is reached on whether the scope name should be changed.

receiver/apachereceiver/testdata/integration/expected.yaml Outdated Show resolved Hide resolved
@codeboten codeboten mentioned this pull request May 1, 2023
Merged
@atoulme atoulme mentioned this pull request May 1, 2023
Closed
@dmitryax dmitryax mentioned this pull request May 3, 2023
Open
@codeboten codeboten added the on hold This is blocked by another PR/issue label May 3, 2023
@fatsheep9146
Copy link
Contributor

I think on hold can be removed since #21382 is closed?

@atoulme
Copy link
Contributor Author

atoulme commented May 11, 2023

Sure, and we need to rebase and regenerate those files, should be doable.

@atoulme atoulme removed on hold This is blocked by another PR/issue discussion needed Community discussion needed labels May 11, 2023
@atoulme atoulme force-pushed the use_type_in_apache_receiver branch 3 times, most recently from 17e02c3 to 09559a7 Compare May 11, 2023 03:44
@atoulme atoulme force-pushed the use_type_in_apache_receiver branch from 09559a7 to 9081c74 Compare May 11, 2023 03:46
@atoulme atoulme requested a review from codeboten May 11, 2023 03:46
@dmitryax dmitryax dismissed codeboten’s stale review May 11, 2023 17:34

this is not affecting the generated scope name anymore

@dmitryax dmitryax merged commit fca3245 into open-telemetry:main May 11, 2023
@github-actions github-actions bot added this to the next release milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley left review comments

@Aneurysm9 Aneurysm9 Aneurysm9 left review comments

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@fatsheep9146 fatsheep9146

Labels
receiver/apache
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@atoulme @fatsheep9146 @codeboten @Aneurysm9 @djaglowski @dmitryax @evan-bradley