[chore] use type in aerospike receiver #21271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
use_type_in_aerospikereceiver
branch
2 times, most recently
from
8c7f512 to
8414a5b
Compare
evan-bradley
reviewed
May 1, 2023
There was a problem hiding this comment.
I think this will need a changelog entry since we're changing the instrumentation scope name on the emitted metrics. Per the scraping receivers stability guarantees for a component with alpha stability, I think a breaking change will be fine here, but we can lean on the code owners to make that decision.
codeboten
requested changes
May 1, 2023
There was a problem hiding this comment.
Requesting change for the same reason as #21272 (review), @atoulme could you open an issue to track this? It would be good to come to an agreement in the issue and reference it in any changes we make.
|
#21382 is filed |
atoulme
force-pushed
the
use_type_in_aerospikereceiver
branch
from
8414a5b to
b8a9f3b
Compare
|
No changes to scope name anymore, so we will be good with minimal changes now. |
djaglowski
approved these changes
May 11, 2023
|
@codeboten PTAL |
codeboten
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses metadata.Type in the code of the aerospike receiver.