fix make for golang 1.20 #20347
Merged
fix make for golang 1.20 #20347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmolenda-sumo
requested review from
jpkrohling,
dmitryax,
atoulme,
Aneurysm9 and
MovieStoreGuy
as code owners
github-actions
bot
added
exporter/awskinesis
exporter/awsxray
exporter/azuredataexplorer
exporter/instana
exporter/sapm
processor/servicegraph
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 6 seconds (30 minutes 37 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 56 seconds and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute 19 seconds and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 2 minutes 1 second and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 6 seconds (3 minutes 19 seconds less than main branch avg.) and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | N/A | See Details |
✅ e2e-tests workflow has finished in 12 minutes 39 seconds and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| kubernetes-test (v1.26.0) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.25.3) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.24.7) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.23.13) | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 16 minutes 50 seconds (⚠️ 6 minutes 18 seconds more than main branch avg.) and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| setup-environment | - 🔗 | N/A | See Details |
| loadtest (TestIdleMode) | - 🔗 | N/A | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | N/A | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | N/A | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | N/A | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | N/A | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | N/A | See Details |
| loadtest (TestTraceAttributesProcessor) | - 🔗 | N/A | See Details |
❌ build-and-test workflow has finished in 17 minutes 53 seconds (28 minutes 56 seconds less than main branch avg.) and finished at 12th Apr, 2023. 5 jobs failed.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| govulncheck | - 🔗 | N/A | See Details |
| setup-environment | - 🔗 | N/A | See Details |
| check-codeowners | - 🔗 | N/A | See Details |
| check-collector-module-version | - 🔗 | N/A | See Details |
| lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
| lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
| lint-matrix (processor) | - 🔗 | N/A | See Details |
| lint-matrix (exporter) | Lint 🔗 | N/A | See Details |
| lint-matrix (extension) | - 🔗 | N/A | See Details |
| lint-matrix (connector) | - 🔗 | N/A | See Details |
| lint-matrix (internal) | - 🔗 | N/A | See Details |
| lint-matrix (other) | - 🔗 | N/A | See Details |
| checks | - 🔗 | N/A | See Details |
| correctness-metrics | - 🔗 | N/A | See Details |
| correctness-traces | - 🔗 | N/A | See Details |
| integration-tests | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, receiver-1) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, processor) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, receiver-0) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, exporter) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, extension) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, connector) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, internal) | - 🔗 | N/A | See Details |
| unittest-matrix (1.20, other) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, receiver-0) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, receiver-1) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, processor) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, exporter) | Run Unit Tests 🔗 | N/A | See Details |
| unittest-matrix (1.19, extension) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, connector) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, internal) | - 🔗 | N/A | See Details |
| unittest-matrix (1.19, other) | - 🔗 | N/A | See Details |
| build-examples | - 🔗 | N/A | See Details |
| unittest (1.20) | Interpret result 🔗 | N/A | See Details |
| unittest (1.19) | Interpret result 🔗 | N/A | See Details |
| lint | Interpret result 🔗 | N/A | See Details |
| cross-compile | - 🔗 | N/A | See Details |
| windows-msi | - 🔗 | N/A | See Details |
| build-package | - 🔗 | N/A | See Details |
| publish-check | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
| publish-dev | - 🔗 | N/A | See Details |
| rotate-milestone | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
dmolenda-sumo
force-pushed
the
fix-make-for-golang-1.20
branch
from
7e7a48d to
45f029e
Compare
|
LGTM. Thank you for the fix - is there any way to avoid panics? |
codeboten
reviewed
Mar 29, 2023
exporter/instanaexporter/internal/converter/span_converter_test.go
Outdated
Show resolved
Hide resolved
Aneurysm9
reviewed
Mar 29, 2023
exporter/awskinesisexporter/internal/compress/compresser_test.go
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Apr 11, 2023
exporter/instanaexporter/internal/converter/span_converter_test.go
Outdated
Show resolved
Hide resolved
dmolenda-sumo
commented
Apr 12, 2023
exporter/instanaexporter/internal/converter/span_converter_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Boten <[email protected]>
dmolenda-sumo
force-pushed
the
fix-make-for-golang-1.20
branch
from
2cf822b to
b0d32ef
Compare
codeboten
approved these changes
May 8, 2023
|
Is it necessary for someone else to review this pull request before merging the changes? |
codeboten
approved these changes
May 11, 2023
Nope! i was just waiting for CI to finish and forgot to come back to it :) Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixing a bug for golang 1.20
math/rand is deprecated and should not be used in golang 1.20. I changed it to crypto/rand and thanks to that make on golag 1.20 works
Link to tracking Issue: #20341
Testing: run make