[processor/servicegraphprocessor] make command doesn't work on golang 1.20 #20341
Assignees
Labels
Comments
dmolenda-sumo
added
bug
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
codeboten
added a commit
that referenced
this issue
May 11, 2023
math/rand is deprecated and should not be used in golang 1.20. I changed it to crypto/rand and thanks to that make on golag 1.20 works Link to tracking Issue: #20341 --------- Co-authored-by: Alex Boten <[email protected]>
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
processor/servicegraph
What happened?
Description
make command doesn't work on golang 1.20
Steps to Reproduce
run make command
Expected Result
everything works :)
Actual Result
error:
processor_test.go:296:2: SA1019: rand.Read has been deprecated since Go 1.20 because it shouldn't be used: For almost all use cases, crypto/rand.Read is more appropriate. (staticcheck) rand.Read(traceID[:]) ^ processor_test.go:299:2: SA1019: rand.Read has been deprecated since Go 1.20 because it shouldn't be used: For almost all use cases, crypto/rand.Read is more appropriate. (staticcheck) rand.Read(clientSpanID[:]) ^ processor_test.go:300:2: SA1019: rand.Read has been deprecated since Go 1.20 because it shouldn't be used: For almost all use cases, crypto/rand.Read is more appropriate. (staticcheck) rand.Read(serverSpanID[:]) ^ make[2]: *** [lint] Error 1 make[1]: *** [processor/servicegraphprocessor] Error 2 make: *** [all-common] Error 2Collector version
latest
Environment information
golang 1.20.2
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: