-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/headersetter] Rename headerssetter
to headerssetterextension
#13900
Conversation
84e9f3b
to
776fc1c
Compare
I don't think we should strive for maintaining a not breaking developer API in this repo at this point. As long as the configuration interface is not changed (I believe it's still cc @jpkrohling |
That's true, but I also think we should try to have it backward compatible whenever possible, especially to create the right culture for the time we actually need to be backward compatible :-) But if other approvers and maintainers think this should be done in a breaking manner, I'm fine with that as well. |
@open-telemetry/collector-contrib-approvers could someone from approvers and maintainer give their opinion on modules bwc approach? |
Need a rebase |
…ion. Deprecate the `github.com/open-telemetry/opentelemetry-collector-contrib/extension/headerssetter` module.
rebased |
@jpkrohling can you please merge it? |
headerssetter
to headerssettersextension
headerssetter
to headerssetterextension
Description:
Rename
headerssetter
toheaderssettersextension
and deprecate thegithub.jparrowsec.cn/open-telemetry/opentelemetry-collector-contrib/extension/headerssetter
module.Link to tracking Issue:
Resolves #13774