Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/headersetter] Rename headerssetter to headerssetterextension #13900

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Sep 6, 2022

Description:

Rename headerssetter to headerssettersextension and deprecate the github.com/open-telemetry/opentelemetry-collector-contrib/extension/headerssetter module.

Link to tracking Issue:
Resolves #13774

@kovrus kovrus marked this pull request as ready for review September 6, 2022 14:57
@kovrus kovrus requested a review from a team September 6, 2022 14:57
@kovrus kovrus requested a review from jpkrohling as a code owner September 6, 2022 14:57
@kovrus kovrus force-pushed the issue-13774 branch 3 times, most recently from 84e9f3b to 776fc1c Compare September 6, 2022 15:30
@dmitryax
Copy link
Member

dmitryax commented Sep 6, 2022

I don't think we should strive for maintaining a not breaking developer API in this repo at this point. As long as the configuration interface is not changed (I believe it's still headersetter in the config, right?), I'd recommend just renaming the module.

cc @jpkrohling

@jpkrohling
Copy link
Member

I don't think we should strive for maintaining a not breaking developer API in this repo at this point.

That's true, but I also think we should try to have it backward compatible whenever possible, especially to create the right culture for the time we actually need to be backward compatible :-) But if other approvers and maintainers think this should be done in a breaking manner, I'm fine with that as well.

@kovrus
Copy link
Member Author

kovrus commented Sep 20, 2022

@open-telemetry/collector-contrib-approvers could someone from approvers and maintainer give their opinion on modules bwc approach?

@bogdandrutu
Copy link
Member

Need a rebase

…ion.

Deprecate the `github.com/open-telemetry/opentelemetry-collector-contrib/extension/headerssetter` module.
@kovrus
Copy link
Member Author

kovrus commented Sep 21, 2022

rebased

@kovrus
Copy link
Member Author

kovrus commented Sep 26, 2022

@jpkrohling can you please merge it?

@kovrus kovrus changed the title [extension/headersetter] Rename headerssetter to headerssettersextension [extension/headersetter] Rename headerssetter to headerssetterextension Sep 26, 2022
@jpkrohling jpkrohling merged commit 62db139 into open-telemetry:main Sep 26, 2022
@kovrus kovrus deleted the issue-13774 branch October 17, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header setter module name should contain "extension"
4 participants