Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header setter module name should contain "extension" #13774

Closed
jpkrohling opened this issue Sep 1, 2022 · 0 comments · Fixed by #13900
Closed

Header setter module name should contain "extension" #13774

jpkrohling opened this issue Sep 1, 2022 · 0 comments · Fixed by #13900
Assignees
Labels
bug Something isn't working extension/headerssetter priority:p2 Medium

Comments

@jpkrohling
Copy link
Member

I should have caught this during the review for the initial version: the header setter extension is currently named "headersetter" in the module and directory name within the "extension" package. Other components do have their types as part of the name, and this is our current convention, so, we should change this. To avoid breaking current users of that extension, we should probably just copy it to the corrected name and deprecate the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension/headerssetter priority:p2 Medium
Projects
None yet
3 participants