Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fp16 utils from mmcv #200

Closed
wants to merge 11 commits into from
Closed

Use fp16 utils from mmcv #200

wants to merge 11 commits into from

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Oct 18, 2020

Fix #153

@jin-s13 jin-s13 requested a review from innerlee October 18, 2020 11:27
@jin-s13 jin-s13 mentioned this pull request Oct 18, 2020
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #200 (07204a3) into master (6268fcd) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   83.84%   84.53%   +0.69%     
==========================================
  Files         114      108       -6     
  Lines        7070     6921     -149     
  Branches     1118     1071      -47     
==========================================
- Hits         5928     5851      -77     
+ Misses        941      871      -70     
+ Partials      201      199       -2     
Flag Coverage Δ
unittests 84.53% <100.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/__init__.py 100.00% <ø> (ø)
mmpose/apis/train.py 18.75% <100.00%> (+1.72%) ⬆️
mmpose/core/post_processing/group.py 84.81% <100.00%> (ø)
mmpose/models/detectors/base.py 63.46% <100.00%> (+4.76%) ⬆️
mmpose/models/detectors/bottom_up.py 64.88% <100.00%> (+0.82%) ⬆️
mmpose/models/detectors/mesh.py 92.62% <100.00%> (+0.38%) ⬆️
mmpose/models/detectors/top_down.py 79.14% <100.00%> (ø)
mmpose/models/losses/mesh_loss.py 97.76% <100.00%> (+0.08%) ⬆️
mmpose/models/losses/mse_loss.py 100.00% <100.00%> (ø)
mmpose/models/losses/multi_loss_factory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6268fcd...54eb7de. Read the comment docs.

@innerlee innerlee requested a review from hellock October 18, 2020 13:49
@innerlee
Copy link
Contributor

I haven't got the chance to try fp16, so @hellock may review this

@hellock
Copy link
Member

hellock commented Oct 29, 2020

How about the benchmark?

@jin-s13
Copy link
Collaborator Author

jin-s13 commented Nov 24, 2020

Still have some problems to solve:

  1. The training is not stable... The accuracy is normal at first, however, it will suddenly decline to 0 at some point (about 140 epochs).
  2. The results may contain NAN values.
  3. Currently, the loss calculation & post-processing use fp32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fp16 utils from mmcv
4 participants