Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Search/Filter functionality for execution tasks names #14547

Merged
merged 7 commits into from
Jan 5, 2024
Merged

UI: Search/Filter functionality for execution tasks names #14547

merged 7 commits into from
Jan 5, 2024

Conversation

dechoma
Copy link
Contributor

@dechoma dechoma commented Jan 2, 2024

Describe your changes:

Fixes #14545

This PR introduces search ( by task name) functionality for pipeline execution tasks

Screen.Recording.2024-01-02.at.14.12.24.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@dechoma dechoma marked this pull request as ready for review January 2, 2024 13:41
@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Jan 2, 2024
@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 51%
 51.52% (25835/50146) 33.75% (10165/30120) 32.51% (2969/9132)

@cypress Cypress
Copy link

cypress bot commented Jan 2, 2024 •
edited
Loading

16 failed tests on run #32807 ↗︎

16 488 8 0 Flakiness 0

Details:

Merge branch 'main' into search_exec_task
Project: openmetadata Commit: 4ce9ea942b
Status: Failed Duration: 41:02 💡
Started: Jan 5, 2024 1:04 PM Ended: Jan 5, 2024 1:45 PM
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-mysql-oss-7421995185-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Failed  Pages/ServiceVersionPage.spec.js • 1 failed test • cypress-ci-mysql-oss-7421995185-1

View Output Video

Test Artifacts
Common prerequisite for service version test > Search service version page > Search version page should show version details after soft deleted Screenshots Video
Failed  Flow/AddAndRemoveTierAndOwner.spec.js • 4 failed tests • cypress-ci-mysql-oss-7421995185-1

View Output Video

Test Artifacts
Add and Remove Owner > topic details page Screenshots Video
Add and Remove Owner > pipeline details page Screenshots Video
Add and Remove Owner > mlmodel details page Screenshots Video
Add and Remove Owner > databaseSchema details page Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 4 failed tests • cypress-ci-mysql-oss-7421995185-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data consumer role > All permissible actions on search index details page should work properly Screenshots Video
Prerequisite for data steward role tests > Add data steward role to the user Screenshots Video
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
SearchIndexDetails page should work properly for admin role > All permissible actions on search index details page should work properly Screenshots Video
Failed  Flow/TagsAddRemove.spec.js • 1 failed test • cypress-ci-mysql-oss-7421995185-1

View Output Video

Test Artifacts
Check if tags addition and removal flow working properly from tables > Adding & removing tags to the containers entity Screenshots Video

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

Review all test suite changes for PR #14547 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani enabled auto-merge (squash) January 5, 2024 13:12
@chirag-madlani chirag-madlani merged commit dc31bc7 into open-metadata:main Jan 5, 2024
13 of 21 checks passed
@dechoma dechoma deleted the search_exec_task branch June 11, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: introduce search for pipeline tasks statuses
3 participants
@dechoma @chirag-madlani @karanh37