Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multilingual Support in EntityLink #13826

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add Multilingual Support in EntityLink #13826

merged 3 commits into from
Nov 2, 2023

Conversation

ayush-shah
Copy link
Member

Describe your changes:

Fixes #13755

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ayush-shah ayush-shah added the bug Something isn't working label Nov 2, 2023
@ayush-shah ayush-shah self-assigned this Nov 2, 2023
@ayush-shah ayush-shah requested a review from a team as a code owner November 2, 2023 07:31
@ayush-shah ayush-shah requested a review from a team November 2, 2023 07:31
@github-actions github-actions bot added Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Nov 2, 2023
@ayush-shah ayush-shah changed the title Add Multilingualsupport in EntityLink Add Multilingual Support in EntityLink Nov 2, 2023
Sachin-chaurasiya
Sachin-chaurasiya previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayush-shah 🙌

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ayush-shah ayush-shah merged commit 0a04ce8 into main Nov 2, 2023
@ayush-shah ayush-shah deleted the add-multilingualsupport branch November 2, 2023 09:05
ayush-shah added a commit that referenced this pull request Nov 6, 2023
@ayush-shah
Add Multilingual Support in EntityLink (#13826)
8088494
@Ashish8689 Ashish8689 mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

Assignees

@ayush-shah ayush-shah

Labels
backend bug Something isn't working Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug on activity_feed & tasks
2 participants
@ayush-shah @Sachin-chaurasiya