Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): teams page improvements #12603

Merged
merged 26 commits into from
Jul 31, 2023
Merged

Conversation

Sachin-chaurasiya
Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya commented Jul 26, 2023

Describe your changes:

I worked on teams page improvements

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
51.19% (20376/39801) 30.21% (7705/25508) 31.48% (2284/7255)

@cypress
Copy link

cypress bot commented Jul 26, 2023

Passing run #26960 ↗︎

0 279 37 0 Flakiness 0

Details:

Merge branch 'main' into pr/teams-page-improvements
Project: openmetadata Commit: 15dc464d19
Status: Passed Duration: 31:46 💡
Started: Jul 31, 2023 11:00 AM Ended: Jul 31, 2023 11:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test July 31, 2023 10:30 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 3b0b2ef into main Jul 31, 2023
@chirag-madlani chirag-madlani deleted the pr/teams-page-improvements branch July 31, 2023 12:57
Sachin-chaurasiya added a commit that referenced this pull request Jul 31, 2023
* chore(ui): teams page improvements

* chore(ui): fetch basic and advanced details separately

* chore(ui): only fetch asset for team type group

* chore(ui): do not load page for advanced details

* chore(ui): fetch all team advanced details separately

* fix: unit test

* test: cypress test for team

* test: fix cypress test

* fix: cypress test

* fix: cy test

---------

Co-authored-by: Chirag Madlani <[email protected]>
(cherry picked from commit 3b0b2ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants