Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team page does not paginate API request #10702

Closed
TeddyCr opened this issue Mar 22, 2023 · 1 comment
Closed

Team page does not paginate API request #10702

TeddyCr opened this issue Mar 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working P0 Highest priority support UI UI specific issues

Comments

@TeddyCr
Copy link
Contributor

TeddyCr commented Mar 22, 2023

Affected module
[UI]

Describe the bug
When navigating to the teams page of the UI, the request to fetch the team is not paginated properly (i.e. limit=100000) which in certain scenario will cause the request to timeout.

To Reproduce
Create a large number of teams and navigate to the teams page

Screenshots or steps to reproduce
Here is a sample request

http://localhost:8585/api/v1/teams?fields=defaultRoles%2CuserCount%2CchildrenCount%2Cowns%2Cparents&limit=100000&parentTeam=Organization&include=all

Expected behavior
Similar to how roles, users, policies and admins have a pagination set to 15, teams page should have a similar behavior.

Version:

  • OpenMetadata version: 0.13.2

Additional context
Slack thread 👉 https://openmetadata.slack.com/archives/C02B6955S4S/p1679470435365239

@chirag-madlani
Copy link
Collaborator

We have separated heavy fields from the list API and made a separate API call for the same.
While fetching additional details we have added a loader to specific for those details in this chore(ui): teams page improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Highest priority support UI UI specific issues
Projects
None yet
Development

No branches or pull requests

4 participants