Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#6741): use antlr parser for fqn and entityLink #12324

Merged
merged 14 commits into from
Jul 11, 2023
Merged

chore(#6741): use antlr parser for fqn and entityLink #12324

merged 14 commits into from
Jul 11, 2023

Conversation

Sachin-chaurasiya
Copy link
Contributor

Describe your changes:

Closes #6741

I worked on issue #6741

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jul 6, 2023
@github-actions github-actions bot added the UI UI specific issues label Jul 6, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jul 6, 2023
ayush-shah
ayush-shah previously approved these changes Jul 6, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 50.46% (20236/40101) 29.36% (7582/25824) 30.33% (2237/7375)

@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit ce89dbc into main Jul 11, 2023
@chirag-madlani chirag-madlani deleted the issue-6741 branch July 11, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@ayush-shah ayush-shah Awaiting requested review from ayush-shah

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI - use antlr parser for fqn and entityLink
3 participants
@Sachin-chaurasiya @chirag-madlani @ayush-shah