Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - use antlr parser for fqn and entityLink #6741

Closed
2 tasks
ayush-shah opened this issue Aug 16, 2022 · 2 comments · Fixed by #12324
Closed
2 tasks

UI - use antlr parser for fqn and entityLink #6741

ayush-shah opened this issue Aug 16, 2022 · 2 comments · Fixed by #12324
Assignees
@Sachin-chaurasiya
Labels
UI UI specific issues

Comments

@ayush-shah
Copy link
Member

ayush-shah commented Aug 16, 2022 •
edited by Sachin-chaurasiya
Loading

We will have Entitylink antlr grammar implemented and have Javascript variants for Parser, Lexer available in src/generated/antlr under ui directory.
We can use that to parse the entityLink and Fqn to match patterns to create Fqn

  • For activity feeds
  • Test cases

PR: #6673
ref: https://github.com/antlr/antlr4/blob/master/doc/javascript-target.md
@ayush-shah ayush-shah added the UI UI specific issues label Aug 16, 2022
@harshach harshach added the P0 Highest priority label Sep 5, 2022
@Sachin-chaurasiya Sachin-chaurasiya removed the P0 Highest priority label Oct 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya moved this to 📋 Backlog in Release 0.13.0 Oct 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya moved this to 📋 Backlog in Release 0.13.1 Nov 24, 2022
@Sachin-chaurasiya Sachin-chaurasiya moved this to 📋 Backlog in Release 1.0 Jan 4, 2023
@harshach harshach moved this to UI in Release 1.1 May 8, 2023
@Sachin-chaurasiya
Copy link
Contributor

Closing this as we are already using Antlr for parsing the FQNs.

@github-project-automation github-project-automation bot moved this from UI to Done in Release 1.1 May 10, 2023
@Sachin-chaurasiya
Copy link
Contributor

Reopening as it's pending for entity links.

@Sachin-chaurasiya Sachin-chaurasiya moved this from Done to UI in Release 1.1 May 10, 2023
@chirag-madlani chirag-madlani removed their assignment May 29, 2023
@TeddyCr TeddyCr mentioned this issue Jun 30, 2023
Closed
Sachin-chaurasiya added a commit that referenced this issue Jul 6, 2023
@Sachin-chaurasiya
chore(#6741): use antlr parser for fqn and entityLink
f67389b
@Sachin-chaurasiya Sachin-chaurasiya mentioned this issue Jul 6, 2023
Merged
5 tasks
chirag-madlani added a commit that referenced this issue Jul 11, 2023
@Sachin-chaurasiya @chirag-madlani
chore(#6741): use antlr parser for fqn and entityLink (#12324)
ce89dbc 
* chore(#6741): use antlr parser for fqn and entityLink

* chore: use this for class context

* chore: address comments

* chore: convert js to ts

* fix: typescript errors

* fix: entity link split method issue

* fix: split listener

---------

Co-authored-by: Chirag Madlani <[email protected]>
chirag-madlani added a commit that referenced this issue Jul 13, 2023
@Sachin-chaurasiya @chirag-madlani
Task improvements (#12361)
a47e80b 
* chore(#6741): use antlr parser for fqn and entityLink

* chore: use this for class context

* chore: address comments

* chore: convert js to ts

* fix: typescript errors

* fix: entity link split method issue

* fix: split listener

* chore(ui): task UI improvements

* feat: add support for edit task assignees

* fix: validation issue

* minor improvements

* chore: address comments

* chore: show dropdown button on task action button

---------

Co-authored-by: Chirag Madlani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(#6741): use antlr parser for fqn and entityLink open-metadata/OpenMetadata
4 participants
@harshach @chirag-madlani @ayush-shah @Sachin-chaurasiya