New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: `$flagd.timestamp` added to in-process evaluator #512

Merged

toddbaert merged 11 commits into open-feature:main from DBlanchard88:timestamptest

Nov 9, 2023

Contributor

DBlanchard88 commented Oct 21, 2023

added the ability to use $flagd.timestamp
added testing to verify implementation of timestamp

DBlanchard88 requested a review from a team as a code owner

October 21, 2023 17:42

github-actions bot assigned beeme1mr, Kavindu-Dodan and toddbaert

github-actions bot requested review from beeme1mr, Kavindu-Dodan and toddbaert

October 21, 2023 17:42

DBlanchard88 changed the title ~~$flagd.timestamp added to in-process evaluator~~ [flagd] flagd.timestamp added to in-process evaluator

DBlanchard88 changed the title ~~[flagd] flagd.timestamp added to in-process evaluator~~ feat: flagd.timestamp added to in-process evaluator

DBlanchard88 force-pushed the timestamptest branch from fef63d9 to 6de214b Compare

October 21, 2023 17:59

toddbaert changed the title ~~feat: flagd.timestamp added to in-process evaluator~~ feat: $flagd.timestamp added to in-process evaluator

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...st/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...st/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...st/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert requested changes

View reviewed changes

Member

toddbaert left a comment

This is awesome! Thank you! And thanks for adding the solid test. I left a bunch of small nits and style feedback, but this is my only blocker for approval.

DBlanchard88 force-pushed the timestamptest branch 2 times, most recently from 4474b83 to 5381741 Compare

October 23, 2023 17:11

toddbaert reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

.github/workflows/release-please.yml Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

toddbaert reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved

DBlanchard88 force-pushed the timestamptest branch from c646eaa to c8f1384 Compare

October 23, 2023 18:25

toddbaert force-pushed the timestamptest branch from 97fd279 to b0092e1 Compare

October 23, 2023 19:09


          time stamp and testing

8380b5e

Signed-off-by: DBlanchard88 <[email protected]>

DBlanchard88 force-pushed the timestamptest branch from b0092e1 to 8380b5e Compare

October 23, 2023 19:28

toddbaert approved these changes

View reviewed changes

Member

toddbaert left a comment

Approved with minor nits.

DBlanchard88 and others added 2 commits

October 23, 2023 16:13


          Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…

d819194

…s/flagd/resolver/process/targeting/OperatorTest.java

Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: David Blanchard <[email protected]>


          Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…

0f04fc5

…s/flagd/resolver/process/targeting/OperatorTest.java

Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: David Blanchard <[email protected]>

beeme1mr approved these changes

View reviewed changes

Kavindu-Dodan reviewed

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Show resolved Hide resolved

Kavindu-Dodan requested changes

View reviewed changes

...c/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java Outdated Show resolved Hide resolved


          extract test

cf0f3c1

Signed-off-by: DBlanchard88 <[email protected]>

beeme1mr reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

beeme1mr previously requested changes

View reviewed changes

Member

beeme1mr left a comment

Please fix the merge issue in the workflow ci.yml.


          yml file fix

f6b3fa5

Signed-off-by: DBlanchard88 <[email protected]>

toddbaert reviewed

View reviewed changes

...st/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java Outdated Show resolved Hide resolved

DBlanchard88 added 2 commits

November 5, 2023 11:07


          extractSubPro back to private

5fa3f5f

Signed-off-by: DBlanchard88 <[email protected]>


          extractSubPro back to private

687ae40

Signed-off-by: DBlanchard88 <[email protected]>

DBlanchard88 requested review from beeme1mr and Kavindu-Dodan

November 7, 2023 18:00

Kavindu-Dodan approved these changes

View reviewed changes


          Merge branch 'main' into timestamptest

ecb8b3c

github-actions bot assigned thisthat

github-actions bot requested a review from thisthat

November 7, 2023 19:38

thisthat approved these changes

View reviewed changes

thisthat dismissed beeme1mr’s stale review

November 8, 2023 07:23

CI conflicts fixed

toddbaert reviewed

View reviewed changes

...st/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java Show resolved Hide resolved

toddbaert approved these changes

View reviewed changes


          Merge branch 'main' into timestamptest

768774a

github-actions bot requested a review from thisthat

November 9, 2023 16:00

toddbaert merged commit 3a074b2 into open-feature:main

github-actions bot mentioned this pull request

chore(main): release dev.openfeature.contrib.providers.flagd 0.6.7 #483

Merged

DBlanchard88 deleted the timestamptest branch

November 9, 2023 17:24

toddbaert mentioned this pull request

[flagd] Add $flagd.timestamp to in-process evalutor #490

Closed

DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request


          fix: Implement equals for the ImmutableMetadata object (open-feature#512

6253aee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet