Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flagd] Add $flagd.timestamp to in-process evalutor #490

Closed
toddbaert opened this issue Oct 12, 2023 · 3 comments
Closed

[flagd] Add $flagd.timestamp to in-process evalutor #490

toddbaert opened this issue Oct 12, 2023 · 3 comments
Assignees
@DBlanchard88
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Oct 12, 2023 •
edited
Loading

The flagd in-process evaluator needs to have $flagd.timestamp added, so that users can write time-based JsonLogic rules.

See here for doc, and here for the flagd-standalone implementation.

You'll need to add a standard unix timestamp (seconds since 1970) to the evaluation context, similar to the flagKey, here.
@toddbaert toddbaert transferred this issue from open-feature/js-sdk-contrib Oct 12, 2023
@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2023
@DBlanchard88
Copy link
Contributor

ill do it

@toddbaert
Copy link
Member Author

toddbaert commented Oct 19, 2023 •
edited
Loading

Relates to: open-feature/flagd-testbed#74

@toddbaert
Copy link
Member Author

Done with #512

Thanks @DBlanchard88 !

DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this issue Apr 29, 2024
@renovate
chore(deps): update amannn/action-semantic-pull-request digest to 002…
8b9e050 
…82d6 (open-feature#490)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DBlanchard88 DBlanchard88

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddbaert @DBlanchard88