fix: await shutdown in in-process mode #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
toddbaert
commented
Sep 21, 2023
•
toddbaert
commented
- fixes an issue where the gRPC channel wasn't shutdown properly
- uses deadline for shutdown timeout
- fixes related issues in testing with tests trampling on each other
toddbaert
commented
Sep 21, 2023
...flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/GrpcConnector.java
Show resolved
Hide resolved
toddbaert
commented
Sep 21, 2023
...ure/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java
Show resolved
Hide resolved
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/shutdown
branch
from
5235aaf to
f1b0d5c
Compare
...flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/GrpcConnector.java
Outdated
Show resolved
Hide resolved
toddbaert
commented
Sep 21, 2023
...flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/GrpcConnector.java
Outdated
Show resolved
Hide resolved
…s/flagd/resolver/grpc/GrpcConnector.java Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
approved these changes
Sep 21, 2023
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ncy-plugin to v3.6.0 (open-feature#445) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.