Skip to content

Commit 5235aaf

Browse files
committed
fixup: shutdown
1 parent 6885488 commit 5235aaf

File tree

8 files changed

+21
-24
lines changed

8 files changed

+21
-24
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/GrpcConnector.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void shutdown() throws Exception {
9090

9191
try {
9292
if (this.channel != null && !this.channel.isShutdown()) {
93-
this.channel.shutdownNow();
93+
this.channel.shutdown();
9494
this.channel.awaitTermination(this.deadline, TimeUnit.MILLISECONDS);
9595
}
9696
} finally {

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public void shutdown() throws InterruptedException {
8484

8585
try {
8686
if (this.channel != null && !this.channel.isShutdown()) {
87-
this.channel.shutdownNow();
87+
this.channel.shutdown();
8888
this.channel.awaitTermination(this.deadline, TimeUnit.MILLISECONDS);
8989
}
9090
} finally {

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFlagdInProcessCucumberTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import static io.cucumber.junit.platform.engine.Constants.PLUGIN_PROPERTY_NAME;
1010
import static io.cucumber.junit.platform.engine.Constants.GLUE_PROPERTY_NAME;
1111

12-
@Order(value = 0)
12+
@Order(value = Integer.MAX_VALUE)
1313
@Suite
1414
@IncludeEngines("cucumber")
1515
@SelectClasspathResource("features/evaluation.feature")

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFlagdRpcCucumberTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import static io.cucumber.junit.platform.engine.Constants.PLUGIN_PROPERTY_NAME;
1010
import static io.cucumber.junit.platform.engine.Constants.GLUE_PROPERTY_NAME;
1111

12-
@Order(value = 0)
12+
@Order(value = Integer.MAX_VALUE)
1313
@Suite
1414
@IncludeEngines("cucumber")
1515
@SelectClasspathResource("features/evaluation.feature")

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/process/FlagdInProcessSetup.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import io.cucumber.java.BeforeAll;
1212

1313
@Isolated()
14-
@Order(value = 0)
14+
@Order(value = Integer.MAX_VALUE)
1515
public class FlagdInProcessSetup {
1616

1717
private static FeatureProvider provider;

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/rpc/FlagdRpcSetup.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import io.cucumber.java.BeforeAll;
1212

1313
@Isolated()
14-
@Order(value = 0)
14+
@Order(value = Integer.MAX_VALUE)
1515
public class FlagdRpcSetup {
1616

1717
private static FeatureProvider provider;

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/StepDefinitions.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* Common test suite used by both RPC and in-process flagd providers.
3030
*/
3131
@Isolated()
32-
@Order(value = 0)
32+
@Order(value = Integer.MAX_VALUE)
3333
public class StepDefinitions {
3434

3535
private static Client client;

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnectorTest.java

+14-17
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,5 @@
11
package dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.grpc;
22

3-
import dev.openfeature.contrib.providers.flagd.FlagdOptions;
4-
import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.StreamPayload;
5-
import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.StreamPayloadType;
6-
import dev.openfeature.flagd.sync.FlagSyncServiceGrpc;
7-
import dev.openfeature.flagd.sync.SyncService;
8-
9-
import org.junit.jupiter.api.Order;
10-
import org.junit.jupiter.api.Test;
11-
import org.junit.jupiter.api.parallel.Isolated;
12-
import org.mockito.Mockito;
13-
14-
import java.lang.reflect.Field;
15-
import java.time.Duration;
16-
import java.util.concurrent.BlockingQueue;
17-
import java.util.concurrent.TimeUnit;
18-
193
import static org.junit.jupiter.api.Assertions.assertEquals;
204
import static org.junit.jupiter.api.Assertions.assertNotNull;
215
import static org.junit.jupiter.api.Assertions.assertNull;
@@ -24,7 +8,20 @@
248
import static org.mockito.Mockito.times;
259
import static org.mockito.Mockito.verify;
2610

27-
@Order(value = Integer.MAX_VALUE)
11+
import java.lang.reflect.Field;
12+
import java.time.Duration;
13+
import java.util.concurrent.BlockingQueue;
14+
import java.util.concurrent.TimeUnit;
15+
16+
import org.junit.jupiter.api.Test;
17+
import org.mockito.Mockito;
18+
19+
import dev.openfeature.contrib.providers.flagd.FlagdOptions;
20+
import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.StreamPayload;
21+
import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.StreamPayloadType;
22+
import dev.openfeature.flagd.sync.FlagSyncServiceGrpc;
23+
import dev.openfeature.flagd.sync.SyncService;
24+
2825
class GrpcStreamConnectorTest {
2926

3027
private static final Duration MAX_WAIT_MS = Duration.ofMillis(500);

0 commit comments

Comments
 (0)