feat: Default port to 8015 if in-process resolver is used. #523 #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re#523 closes: open-feature#523 Signed-off-by: Simon Schrottner <[email protected]>
|
Thank you @aepfli for the contribution. I left two suggestions |
…re#523 pr comments Signed-off-by: Simon Schrottner <[email protected]>
Kavindu-Dodan
approved these changes
Jun 14, 2024
toddbaert
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #523
This PR
The flagd provider defaults to RPC mode and the corresponding port (8013) using the evaluation proto. If the in-process resolver is selected, it operates in in-process mode using the sync proto, but still uses port 8013, instead of defaulting to the correct port (8015, for the sync proto).
We improve the configuration by defaulting to port 8015 if the in-process resolver is selected.