Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flagd] Default port to 8015 if in-process resolver is used. #523

Closed
toddbaert opened this issue Jun 7, 2024 · 0 comments · Fixed by #524
Closed

[flagd] Default port to 8015 if in-process resolver is used. #523

toddbaert opened this issue Jun 7, 2024 · 0 comments · Fixed by #524

Comments

@toddbaert
Copy link
Member

The flagd provider defaults to RPC mode and the corresponding port (8013) using the evaluation proto. If the in-process resolver is selected, it operates in in-process mode using the sync proto, but still uses port 8013, instead of defaulting to the correct port (8015, for the sync proto).

We should improve the configuration by defaulting to port 8015 if the in-process resolver is selected.
aepfli added a commit to open-feature-forking/go-sdk-contrib that referenced this issue Jun 7, 2024
@aepfli
feat: Default port to 8015 if in-process resolver is used. open-featu…
59bb8d0 
…re#523

closes: open-feature#523
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli mentioned this issue Jun 7, 2024
Merged
aepfli added a commit to open-feature-forking/go-sdk-contrib that referenced this issue Jun 7, 2024
@aepfli
feat: Default port to 8015 if in-process resolver is used. open-featu…
477a564 
…re#523

pr comments

Signed-off-by: Simon Schrottner <[email protected]>
toddbaert pushed a commit that referenced this issue Jun 14, 2024
@aepfli
feat: Default port to 8015 if in-process resolver is used. #523 (#524)
7db1ce3 
Signed-off-by: Simon Schrottner <[email protected]>
@github-actions github-actions bot mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Default port to 8015 if in-process resolver is used. #523 open-feature-forking/go-sdk-contrib
1 participant
@toddbaert