Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add docs about $flag.properties #965

Merged
merged 10 commits into from
Oct 14, 2023
Merged

docs: Add docs about $flag.properties #965

merged 10 commits into from
Oct 14, 2023

Conversation

craigpastro
Copy link
Member

@craigpastro craigpastro commented Oct 12, 2023 •
edited
Loading

This PR

I had a go at adding docs for the $flagd properties. In general, I think this is something that I am terrible at, so please let me know if you have any suggestions.

A couple of other things:

  • I renamed JSON Logic to JsonLogic to be consistent in other places
  • I added some missing periods

Related Issues

Closes #962.

Notes

Follow-up Tasks

How to test

@craigpastro craigpastro requested a review from a team as a code owner October 12, 2023 17:58
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 84de508
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/652aa0936269520008b123cd

markdownlint-fix
2f3b423 
Signed-off-by: Craig Pastro <[email protected]>
beeme1mr
beeme1mr reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments but it looks good to me. Thanks for putting it together.

docs/reference/flag-definitions.md Outdated Show resolved Hide resolved
docs/reference/flag-definitions.md Outdated Show resolved Hide resolved
docs/reference/specifications/in-process-providers.md Show resolved Hide resolved
docs/reference/specifications/in-process-providers.md Outdated Show resolved Hide resolved
@toddbaert toddbaert mentioned this pull request Oct 12, 2023
Closed
Update based on feedback
e46b1b6 
Signed-off-by: Craig Pastro <[email protected]>
@toddbaert toddbaert merged commit 608535a into open-feature:main Oct 14, 2023
@craigpastro craigpastro deleted the docs-for-flagd-properties branch October 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert left review comments

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] ad doc about $flag.properties (flagKey and timestamp)
4 participants
@craigpastro @beeme1mr @Kavindu-Dodan @toddbaert