docs: Add initial flag manifest schema #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anghelflorinm
changed the title
anghelflorinm
force-pushed
the
1-define-initial-flag-manifest
branch
from
3957f81 to
9c8ed43
Compare
Signed-off-by: Florin-Mihai Anghel <[email protected]>
anghelflorinm
force-pushed
the
1-define-initial-flag-manifest
branch
from
9c8ed43 to
a12fb24
Compare
beeme1mr
reviewed
Aug 22, 2024
beeme1mr
reviewed
Aug 22, 2024
moredip
reviewed
Aug 23, 2024
|
FYI I also left some comments in the google doc |
Signed-off-by: Florin-Mihai Anghel <[email protected]>
…he top of the file. Signed-off-by: Florin-Mihai Anghel <[email protected]>
beeme1mr
approved these changes
Aug 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.1...v0.1.0) (2024-10-04) ### ⚠ BREAKING CHANGES * lower json schema version, rename number to float ([#12](#12)) ### ✨ New Features * Fixing problems with generated code for golang and adding sample manifest for testing. ([#22](#22)) ([558e964](558e964)) * initial CLI for codegen with support for golang strongly typed accessors ([#13](#13)) ([e8f3d3e](e8f3d3e)) * lower json schema version, rename number to float ([#12](#12)) ([ed844b4](ed844b4)) ### 📚 Documentation * Add initial flag manifest schema ([#9](#9)) ([fac35ca](fac35ca)) ### 🔄 Refactoring * change the case of the flag manifest to camel case. ([#19](#19)) ([fbac8ce](fbac8ce)) * embed flag manifest schema into code and moves files around ([#18](#18)) ([aa9d3b0](aa9d3b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Defines a new format for a flag manifest input to the codegen tool, as defined in a JSON schema
Related Issues
Fixes #1
Notes
Is based on https://docs.google.com/document/d/19GQpSNcLnDEbzJRL6FpzKHFEQWVGNrgNK25lC4-JuE8/edit#heading=h.f1glu5dk43k9