feat: Fixing problems with generated code for golang and adding sample manifest for testing. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikhaska
changed the title
beeme1mr
reviewed
Oct 2, 2024
added 4 commits
October 2, 2024 22:52
…ng always decode json to float64). Signed-off-by: Dominik Haska <[email protected]>
Signed-off-by: Dominik Haska <[email protected]>
… paramatrise that by languge so we need to have per language additional configs to not touch generator code too much in the future. Signed-off-by: Dominik Haska <[email protected]>
Signed-off-by: Dominik Haska <[email protected]>
Signed-off-by: Dominik Haska <[email protected]>
beeme1mr
approved these changes
Oct 2, 2024
|
Thanks! I'll wait for @anghelflorinm to have a look. Feel free to merge when you're ready. |
anghelflorinm
approved these changes
Oct 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.1...v0.1.0) (2024-10-04) ### ⚠ BREAKING CHANGES * lower json schema version, rename number to float ([#12](#12)) ### ✨ New Features * Fixing problems with generated code for golang and adding sample manifest for testing. ([#22](#22)) ([558e964](558e964)) * initial CLI for codegen with support for golang strongly typed accessors ([#13](#13)) ([e8f3d3e](e8f3d3e)) * lower json schema version, rename number to float ([#12](#12)) ([ed844b4](ed844b4)) ### 📚 Documentation * Add initial flag manifest schema ([#9](#9)) ([fac35ca](fac35ca)) ### 🔄 Refactoring * change the case of the flag manifest to camel case. ([#19](#19)) ([fbac8ce](fbac8ce)) * embed flag manifest schema into code and moves files around ([#18](#18)) ([aa9d3b0](aa9d3b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Several small changes:
Related Issues
No issue - I've just tried to use the code to generate accessors