[Flow EVM] make deposit available for all EVM addresses #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the title
janezpodhostnik
approved these changes
Feb 28, 2024
|
previously we were not sure how to deal with deposits to the smart contract addresses, I found a solution for it #5469, and using a two-step process makes it possible now. |
|
Awesome!
Nevermind, I just saw the target branch. I updated the description. |
…g' into ramtin/5468-part2-deposit-for-all-evm-addresses
Base automatically changed from
ramtin/5468-part1-use-transfer-for-native-token-bridging
to
master
March 5, 2024 20:33
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5473 +/- ##
==========================================
- Coverage 55.84% 55.53% -0.32%
==========================================
Files 1030 957 -73
Lines 100803 95126 -5677
==========================================
- Hits 56295 52829 -3466
+ Misses 40178 38117 -2061
+ Partials 4330 4180 -150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5469
Closes #5468