Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] deposit calls to regular smart contracts expects different behaviour #5227

Closed
Tracked by #5241
ramtinms opened this issue Jan 10, 2024 · 0 comments · Fixed by #5280
Closed
Tracked by #5241

[Flow EVM] deposit calls to regular smart contracts expects different behaviour #5227

ramtinms opened this issue Jan 10, 2024 · 0 comments · Fixed by #5280
Assignees
Labels
Bug Something isn't working Flow EVM
Milestone

Comments

@ramtinms
Copy link
Contributor

Problem definiton

When we make an evm deposit call, the target address can be any address at the moment and we update the balance,
While this is a valid behaviour for EOA addresses for smart contracts the expected behaviour is we can only update the balance if there is a call to the smart contract (reroute to receive and fallback).

Proposed solution

As part of discussed it was decided for better user experience move the deposit logic to COA accounts only. This won't limit the users as they can move money to a COA and then make a transfer call to any other address in a single transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Flow EVM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants