Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow-go dependency to fix tx replay validation #754

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Feb 13, 2025

Related: onflow/flow-go#7023

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Summary by CodeRabbit

  • Chores
    • Updated core project dependencies to their latest stable versions, enhancing performance, reliability, and security.
    • Synchronized integration test dependencies with current releases to ensure robust and consistent testing.
    • Leveraged recent upstream improvements to provide a smoother user experience.
    • These enhancements contribute to improved overall system stability and maintain compatibility with downstream services.

Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

Walkthrough

The changes involve comprehensive updates to dependency versions in two Go module files: the main go.mod and the integration test file tests/go.mod. Both files see several packages upgraded to their latest releases, including direct and indirect dependencies. Additionally, the test module includes extra updates and the addition of a new dependency. These adjustments ensure that the modules are compatible with the most recent library versions.

Changes

File(s) Change Summary
go.mod Updated dependency versions for multiple libraries including: github.com/onflow/flow-go (v0.38.0 → v0.38.1), github.com/prometheus/client_golang (v1.18.0 → v1.20.5), golang.org/x/exp, golang.org/x/sync, google.golang.org/grpc, github.com/cenkalti/backoff/v4, github.com/decred/dcrd/dcrec/secp256k1/v4, github.com/go-logr/logr, github.com/google/pprof, github.com/klauspost/compress, github.com/libp2p/go-libp2p, github.com/multiformats/go-multiaddr, and various go.opentelemetry packages.
tests/go.mod Updated dependency versions in line with the main file for many libraries such as github.com/onflow/flow-go, github.com/cenkalti/backoff/v4, and others; additionally, updated packages unique to tests like github.com/go-logfmt/logfmt, github.com/golang/glog, github.com/gorilla/websocket, github.com/grpc-ecosystem/grpc-gateway/v2, github.com/prometheus/common, github.com/rogpeppe/go-internal, github.com/slok/go-http-metrics, google.golang.org/protobuf; also added github.com/multiformats/go-multiaddr-fmt and removed older OpenTelemetry dependencies.

Possibly related PRs

Suggested labels

Improvement, EVM

Suggested reviewers

  • peterargue
  • zhangchiqing
  • janezpodhostnik

Poem

I'm just a little rabbit, hopping through the code, 🐇
Upgrading dependencies on my joyful road.
New versions bloom like springtime cheer,
Each update whispers, "The latest is here!"
I nibble on changes with a bounce and a wink—
In our garden of code, improvements make me think.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bce988d and f066013.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (8 hunks)
  • tests/go.mod (8 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/go.mod
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test
🔇 Additional comments (4)
go.mod (4)

185-191: Verify compatibility between OpenTelemetry packages.

All OpenTelemetry packages have been updated to v1.31.0, which maintains version consistency across the OpenTelemetry ecosystem.


14-14: Verify compatibility between Prometheus packages.

The Prometheus client and related packages have been updated together:

  • client_golang: v1.20.5
  • client_model: v0.6.1
  • common: v0.61.0
  • procfs: v0.15.1

This maintains version consistency across the Prometheus ecosystem.

Also applies to: 153-155


11-11:

✅ Verification successful

Verify the flow-go version update.

The update to flow-go appears to be targeting a specific commit (77f4db56bb54) which should contain the fix for tx replay validation as mentioned in the PR objectives.


🏁 Script executed:

#!/bin/bash
# Description: Verify the flow-go commit and changes
# Check the commit message and changes in the flow-go repository
gh api repos/onflow/flow-go/commits/77f4db56bb54 --jq '.commit.message'

Length of output: 213


Flow-go dependency update verified for tx replay validation fix

  • The update in go.mod (line 11) to version v0.38.1-0.20250213171922-77f4db56bb54 correctly points to the commit fixing tx replay error message validation (commit message: "Validation of error message on transaction replay is broken").
  • The commit message from the flow-go repository confirms that this change targets the PR’s objective.
  • Other dependency updates appear routine; ensure overall compatibility, but no direct issues have been observed with this update.

23-25:

✅ Verification successful

Verify compatibility with updated core packages.

The following core packages have been updated:

  • golang.org/x/exp: to latest commit
  • golang.org/x/sync: v0.10.0
  • google.golang.org/grpc: v1.67.1

These are significant updates that could introduce breaking changes.


🌐 Web query:

What are the breaking changes in grpc v1.67.1?

💡 Result:

gRPC Java v1.67.1 is primarily a maintenance release addressing regressions and bugs without introducing breaking API changes[1][8]. Key fixes include:

Android Compatibility:

  • Fixed StatusRuntimeException failures on Android API level ≤23 caused by a regression in v1.64.0[1]. Older clients using these APIs would have experienced crashes, making this a critical fix rather than an intentional breaking change.

Security Improvements:

  • Rejected non-ASCII subject alternative names in OkHttp TLS handling (CVE-2021-0341 mitigation)[1]. This hardening doesn't break compliant implementations but provides defense-in-depth against malformed certificates.

Internal Changes:

  • Load balancing policy refactoring for petiole policies (round_robin, ring_hash, etc.) maintained backward compatibility[8].
  • XDS client separation per channel target improved isolation without affecting existing configurations[8].

No intentional backward-incompatible API/behavior changes were documented for this patch release[3][7]. The versioning follows semantic versioning rules where patch releases (third digit) only contain fixes[3].

Citations:


Dependency Updates Verified – No Breaking Changes Detected for gRPC v1.67.1

The following dependency updates in go.mod have been applied:

  • golang.org/x/exp now points to the latest commit.
  • golang.org/x/sync has been updated to v0.10.0.
  • google.golang.org/grpc is updated to v1.67.1.

Based on the release notes, gRPC v1.67.1 is a maintenance patch with no documented backward-incompatible API changes. While this release appears safe, please ensure that:

  • Your full test suite is run to catch any unforeseen issues.
  • You verify that any usage of experimental features in golang.org/x/exp continues to behave as expected.

If all tests pass, these updates should be compatible with our codebase.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@m-Peter m-Peter force-pushed the mpeter/fix-tx-replay-err-message-validation branch from bce988d to f066013 Compare February 13, 2025 18:04
@peterargue peterargue merged commit 6f4a6cb into main Feb 13, 2025
2 checks passed
@m-Peter m-Peter deleted the mpeter/fix-tx-replay-err-message-validation branch February 13, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants