We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following 2 PRs:
ErrorMessageWithRevertReason
improved the errorMessage field of the EVM.TransactionExecuted payload, to also include any revert reason, if present.
errorMessage
EVM.TransactionExecuted
However, the validation of transaction replay logic is sensitive to this, as it performs a strict check on the actual error message (https://github.com/onflow/flow-go/blob/master/fvm/evm/offchain/sync/replay.go#L168-L171).
We can improve this validation check, by simply checking the errorCode field, which is unlikely to change, like the errorMessage content.
errorCode
The text was updated successfully, but these errors were encountered:
m-Peter
Successfully merging a pull request may close this issue.
The following 2 PRs:
ErrorMessageWithRevertReason
when validating replay of EVM tx #6952improved the
errorMessage
field of theEVM.TransactionExecuted
payload, to also include any revert reason, if present.However, the validation of transaction replay logic is sensitive to this, as it performs a strict check on the actual error message (https://github.com/onflow/flow-go/blob/master/fvm/evm/offchain/sync/replay.go#L168-L171).
We can improve this validation check, by simply checking the
errorCode
field, which is unlikely to change, like theerrorMessage
content.The text was updated successfully, but these errors were encountered: