Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Validation of error message on transaction replay is broken #7023

Closed
m-Peter opened this issue Feb 12, 2025 · 0 comments · Fixed by #7026
Closed

[Flow EVM] Validation of error message on transaction replay is broken #7023

m-Peter opened this issue Feb 12, 2025 · 0 comments · Fixed by #7026
Assignees
Labels
Bug Something isn't working Flow EVM

Comments

@m-Peter
Copy link
Collaborator

m-Peter commented Feb 12, 2025

The following 2 PRs:

improved the errorMessage field of the EVM.TransactionExecuted payload, to also include any revert reason, if present.

However, the validation of transaction replay logic is sensitive to this, as it performs a strict check on the actual error message (https://github.com/onflow/flow-go/blob/master/fvm/evm/offchain/sync/replay.go#L168-L171).

We can improve this validation check, by simply checking the errorCode field, which is unlikely to change, like the errorMessage content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Flow EVM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant