feat: calculate tx hash before seal #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lmcmz
previously approved these changes
Jan 9, 2025
src/background/controller/wallet.ts
Outdated
| 0, // Fixed value | ||
| gasLimit, // Gas Limit | ||
| Buffer.from(to, 'hex'), // To Address | ||
| BigInt(amount * 10 ** 18), // Value |
There was a problem hiding this comment.
the amount is already a number
src/background/controller/wallet.ts
Outdated
| // [nonce, gasPrice, gasLimit, to.addressData, value, data, v, r, s] | ||
| const transaction = [ | ||
| Number(addressNonce), // nonce | ||
| 0, // Fixed value |
There was a problem hiding this comment.
can we use the variable instead of magic number ?
const gasPrice = 0
const transaction = [
Number(addressNonce), // nonce
gasPrice,
...
]
src/background/controller/wallet.ts
Outdated
| Buffer.from(dataArray), // Call Data | ||
| 255, // Fixed value | ||
| BigInt('0x' + evmAddress), // From Account | ||
| 5, // SubType |
There was a problem hiding this comment.
Same for 255 and 5.
const directCallTxType = 255
const contractCallSubType = 5
src/background/controller/wallet.ts
Outdated
| const encodedData = encode(transaction); | ||
| const hash = keccak256(Buffer.from(encodedData)); | ||
| const hashHexString = Buffer.from(hash).toString('hex'); | ||
| if (hashHexString) { | ||
| return hashHexString; | ||
| } else { | ||
| console.log('Transaction Executed event not found'); |
There was a problem hiding this comment.
if hashHexString is nil, we need handle the error response.
lmcmz
requested changes
Jan 9, 2025
lmcmz
approved these changes
Jan 9, 2025
src/background/controller/wallet.ts
Outdated
| const contractCallSubType = 5; | ||
| const noceNumber = Number(addressNonce); | ||
| const gasPrice = 0; | ||
| const transactionValue = BigInt(amount * 10 ** 18); |
There was a problem hiding this comment.
Above we already convert hex to number, we can use it redirectly.
the value*10**18 is the example code, I don't wanna add web3js lib.
// Convert the hex value to number
const number = web3.utils.hexToNumber(value);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #336
Summary of Changes
Need Regression Testing
Updated the process when approving dapp ttransaction
Risk Assessment
Need to test if the transaction id is correct across different dapp platforms.
Additional Notes
Screenshots (if applicable)