Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM TX ID Calculation #336

Closed
lmcmz opened this issue Jan 8, 2025 · 1 comment · Fixed by #337
Closed

EVM TX ID Calculation #336

lmcmz opened this issue Jan 8, 2025 · 1 comment · Fixed by #337
Assignees
Labels
enhancement New feature or request

Comments

@lmcmz
Copy link
Contributor

lmcmz commented Jan 8, 2025

Description

Currently, the Flow Wallet requires users to wait until the next transaction is sealed before returning the EVM transaction ID. This creates a poor user experience due to the long wait times. To address this, we need to pre-calculate the EVM transaction ID and return it to the user without waiting for the transaction to be executed or sealed.

This involves:

  1. Fetching the nonce of the COA (Cadence Owned Account).
  2. RLP encoding the transaction and using keccak256 to calculate the hash.
  3. Returning the pre-calculated transaction ID to the EVM dApp immediately.

Detail:
https://app.gitbook.com/o/btnrCjBfFA1CijnAHf9d/s/GYDJkmOw0mtLZ0sqTZ8o/ep.04.02-calculate-tx-id

@lmcmz lmcmz moved this to Todo in Flow Wallet Jan 8, 2025
@lmcmz lmcmz added this to Flow Wallet Jan 8, 2025
@lmcmz lmcmz added the enhancement New feature or request label Jan 8, 2025
@zzggo zzggo moved this from Todo to In Progress in Flow Wallet Jan 8, 2025
@zzggo zzggo moved this from In Progress to Code Review in Flow Wallet Jan 8, 2025
@zzggo zzggo linked a pull request Jan 8, 2025 that will close this issue
5 tasks
@lmcmz lmcmz moved this from Code Review to Ready for QA in Flow Wallet Jan 10, 2025
@Peppermint1020 Peppermint1020 moved this from Ready for QA to In QA in Flow Wallet Jan 13, 2025
@Peppermint1020 Peppermint1020 self-assigned this Jan 13, 2025
@Peppermint1020
Copy link
Contributor

Tested successes on https://github.com/Outblock/FRW-Extension/actions/runs/12685068713

The EVM tx id pre-calculated and return it to the user without waiting for the transaction to be executed or sealed.
The process video is attached.

Screen.Recording.2025-01-14.at.12.48.50.pm.mov

@Peppermint1020 Peppermint1020 moved this from In QA to Done in Flow Wallet Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants