Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

144-FEATURE-Improve-code-formatting-and-linting #150

Merged

Conversation

tombeckenham
Copy link
Collaborator

I've created a setup for linting and prettier. Note that I have run prettier on all files, but not fixed any lint errors. That would be best to do on a file by file basis

Fixes #144

@tombeckenham
Copy link
Collaborator Author

NOTE: Do not merge this PR yet. First check if these settings work with your editor and general coding style. If so, we need to run prettier on every single file in the repo before merging - it will change almost every file which will make it hard to figure out changes

@lmcmz lmcmz requested a review from zzggo November 7, 2024 11:59
Copy link
Collaborator Author

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be merged when ready

Copy link
Collaborator Author

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When approved I mean!

@tombeckenham tombeckenham merged commit b116aaf into master Nov 10, 2024
1 check passed
@tombeckenham tombeckenham deleted the tombeckenham/144-FEATURE-Improve-code-formatting-and-linting branch November 10, 2024 21:17
@tombeckenham tombeckenham restored the tombeckenham/144-FEATURE-Improve-code-formatting-and-linting branch November 10, 2024 23:23
@tombeckenham tombeckenham deleted the tombeckenham/144-FEATURE-Improve-code-formatting-and-linting branch November 10, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve code formatting and linting
2 participants