Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve code formatting and linting #144

Closed
tombeckenham opened this issue Nov 5, 2024 · 0 comments · Fixed by #150 or #157
Closed

[FEATURE] Improve code formatting and linting #144

tombeckenham opened this issue Nov 5, 2024 · 0 comments · Fixed by #150 or #157
Assignees

Comments

@tombeckenham
Copy link
Collaborator

Issue to be solved

There is currently no unified approach to code formatting and linting. This makes it hard to collaborate on the code base. Saving a file on one machine may completely change the formatting of the whole file. This makes it difficult to see which parts of the code properly were altered when reviewing PRs. Although the project has a prettier and eslint setting, there is no editor config which forces the format on save option. That's produced code that is not uniformly formatted - some lines are formatted one way, and other lines in the same file are formatted another

Suggest A Solution

  1. Tighten up the prettier and eslint settings. They are currently too loose
  2. Introduce an editor config file that forces format on save
  3. Add a GitHub action that prevents code from being checked in or merged if it does not follow the formatting rules
@tombeckenham tombeckenham moved this to Todo in Flow Wallet Nov 5, 2024
tombeckenham added a commit that referenced this issue Nov 7, 2024
tombeckenham added a commit that referenced this issue Nov 7, 2024
tombeckenham added a commit that referenced this issue Nov 8, 2024
@Peppermint1020 Peppermint1020 moved this from Ready for QA to Done in Flow Wallet Nov 11, 2024
@tombeckenham tombeckenham linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant