Add web files required by rosie disco (only) #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've traced the single test failure in metomi#2357 to a lack of HTML, CSS & JS files required by the Rosie Disco Service when it runs in the browser, as standard (see metomi#2355 (comment)). These were removed from the
master
(Rose 2) branch during metomi#2318.This PR re-adds the directories & the required web files as in the current
7.8.x
branch, excluding those explicitly referencing Rose Bush.Since only the full directory is explicitly referenced to be read:
https://github.com/metomi/rose/blob/a2309eb25e6768d9c0628d9da75e1f3adb9f91b5/lib/python/rosie/ws.py#L135-L136
... I am not sure of a way to determine which files under
lib/html/static/
are used by Rosie Disco Service & which were used only by Rose Bush, so the latter can be removed. Any ideas on how to filter out such Rose Bush files so I can remove them from this PR? Otherwise, I think for not we should just re-add everything understatic/
, as we may well be adjusting the front-end soon, so I am not sure it is worth too much effort to manually trawl through these.