Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: okta_app_group_assignments #498

Merged
merged 11 commits into from
Jun 22, 2021

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented May 31, 2021

Creates a new data source, intended to replace the groups data on the okta_app_* resources.

Initial implementation only provides the list of groups IDs, much like the groups interface does.

@ymylei ymylei changed the title New data source: `okta_app_group New data source: okta_app_group_assignments May 31, 2021
@ymylei
Copy link
Contributor Author

ymylei commented May 31, 2021

Acceptance test results:

<pruned>

@ymylei
Copy link
Contributor Author

ymylei commented May 31, 2021

Updated test results:

➜  terraform-provider-okta git:(data_okta_group_assignments) TEST_FILTER="TestAccOktaDataSourceAppGroupAssignments_read" make testacc
go mod tidy
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -run TestAccOktaDataSourceAppGroupAssignments_read -timeout 120m
?       github.com/okta/terraform-provider-okta [no test files]
=== RUN   TestAccOktaDataSourceAppGroupAssignments_read
--- PASS: TestAccOktaDataSourceAppGroupAssignments_read (12.02s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    12.247s
?       github.com/okta/terraform-provider-okta/sdk     [no test files]

@bogdanprodan-okta bogdanprodan-okta merged commit f53a9d5 into okta:master Jun 22, 2021
ymylei added a commit to ymylei/terraform-provider-okta that referenced this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants