Deprecate users and groups field in the okta_app_* data sources
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymylei
changed the title
users and groups field in the okta_app data sourceusers and groups field in the okta_app data source
ymylei
changed the title
users and groups field in the okta_app data sourceusers and groups field in the okta_app_* data sources
|
Hi @ymylei! Because we are planning to release 4.x.x version, we are going to remove all the |
|
@bogdanprodan-okta I believe that is a mistake on your part. According to the deprecation best practices from Hashi (https://www.terraform.io/docs/extend/best-practices/deprecations.html) we should be releasing a "deprecated" release before you remove anything in a major cut. |
bogdanprodan-okta
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecations to these fields ahead of their removal. Requires the replacement data sources below (if deprecation messages are not going to be altered or functionality not replaced).
Replacement data sources:
groups: New data source:okta_app_group_assignments#498users: New data source:okta_app_user_assignments#501