Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leak by using Unix.close_process_in instead of close_in #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix resource leak by using Unix.close_process_in instead of close_in #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions config.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ let get_command_output cmd =
let ic = Unix.open_process_in cmd in
try
let output = input_line ic in
close_in ic;
let _ = Unix.close_process_in ic in
if String.trim output = "" then "N/A" else output
with End_of_file -> (
close_in ic;
with
| End_of_file ->
let _ = Unix.close_process_in ic in
"N/A"
)

let rec prompt_input prompt validate error_message =
print_string (cyan "→ " ^ bold prompt ^ ": ");
Expand Down