Fix resource leak by using Unix.close_process_in instead of close_in #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `close_in ic` with `Unix.close_process_in ic` to correctly close the process opened by `Unix.open_process_in`. - Ensured that the process is properly closed even in case of exceptions (e.g., `End_of_file`). - This prevents resource leaks and ensures proper process termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Resource Leak in
get_command_outputThe original code used
close_into close a process opened byUnix.open_process_in, which is incorrect and can lead to resource leaks. This PR fixes the issue by usingUnix.close_process_into properly close the process.Changes:
close_in icwithUnix.close_process_in ic.Impact: