Fix some leaks and types in fsevent-sys #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that str_path_to_cfstring_ref handles errors in all codepaths, and doesn't leak resources upon failure.
erickt
changed the title
|
Thanks for all these changes! 🙇🏻 |
octplane
reviewed
May 12, 2021
There was a problem hiding this comment.
I have reverted 8835fa0 for now as it's crashing the tests on my machine:
running 4 tests
error: test failed, to rerun pass '--test fsevent'
Caused by:
process didn't exit successfully: `/Users/pierre.baillet/src/mine/fsevent-rust/target/debug/deps/fsevent-86fef05a90526088` (signal: 4, SIGILL: illegal instruction)
cc @erickt
|
I have pushed back most of the changes, except the loop part that's creating the issue. I'll try and have a look later... |
|
I've have pushed a fix with your code b17d5ee#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R385, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As best as I can tell,
CFURLCreateFileReferenceURLandCFURLCreateFilePathURLdo not free the passed in url upon error. This change makes sure we release the
url on success or failure.